Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Added numpy bound to the requirements file #580

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fnhirwa
Copy link

@fnhirwa fnhirwa commented Aug 19, 2024

Description

This PR adds the numpy bounds for the case where numpy 2 isn't supported yet and added the version to __init__ file for local development, and this will require to bump a version into the __init__ file at every release.

Fixes #579

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Please also list any relevant details
for your test configuration

  • Installed pmdarima from this branch and got the numpy version that is lower than numpy 2
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@fnhirwa fnhirwa marked this pull request as ready for review August 19, 2024 16:34
@fnhirwa fnhirwa marked this pull request as draft August 19, 2024 17:05
@fnhirwa fnhirwa marked this pull request as ready for review August 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding bounds for numpy in the build requirements and Adding version for build from source
1 participant